Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish an official NPM package #9

Open
dtaylor113 opened this issue Feb 10, 2016 · 7 comments
Open

Please publish an official NPM package #9

dtaylor113 opened this issue Feb 10, 2016 · 7 comments

Comments

@dtaylor113
Copy link

Hi,
We use google-code-prettify as a dependency in our PatternFly toolkit (patternfly.org), however some of our consumers only use NPM to install PatternFly, so they currently can not get the google-code-prettify dependency since there isn't currently an official published NPM package for google-code-prettify

We are planning on publishing an NPM for google-code-prettify, but it would be ideal if there was an official NPM.

Thanks,
Dave Taylor

@wheelerlaw
Copy link

@emeraldjava
Copy link

I think if a team is using a maven build, the jar files are loaded from

http://www.webjars.org/npm

The google-code-prettify doesn't appear in the npm area here. It does in the bower area.

@emeraldjava
Copy link

@dtaylor113 Is there a workaround to exclude the 'google-code-prettify' from the patternfly build or load the jar file from a different maven repo?

@emeraldjava
Copy link

It seems there is some missing metadata in the package.json which means webjars can't publish the artifact. webjars/webjars#1551

@wheelerlaw
Copy link

Well, the package.json is looking pretty bare if you ask me:

{
	"name": "google-code-prettify",
	"version": "1.0.5",
	"dependencies": {}
}

@emeraldjava
Copy link

emeraldjava commented Feb 14, 2017

I've posted a pull request #14 which adds the required license details to the module.

@emeraldjava
Copy link

@dtaylor113 I've forked the project and added the Apache 2.0 which ensures npm webjars should have a v1.0.5 version in a few hours.

GroupID = org.webjars.npm
ArtifactID = github-com-emeraldjava-google-code-prettify
Version = 1.0.5

Can you test if patternfly will build if you update to reference this version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants