Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize samples by the matcher #317

Open
spenserblack opened this issue Mar 7, 2024 · 0 comments
Open

Organize samples by the matcher #317

spenserblack opened this issue Mar 7, 2024 · 0 comments
Assignees

Comments

@spenserblack
Copy link
Owner

spenserblack commented Mar 7, 2024

This is roughly how linguist does it. They put samples that should be matched by filename in samples/LANGUAGE/filenames/ (extension tests just go in samples/LANGUAGE/).

On a slightly related note, perhaps the "from string" method on Language should be replaced with reversing the name to the language for samples tests, with a pub(crate) method to reverse the variant name to the variant for .gitattributes 🤔

@github-project-automation github-project-automation bot moved this to Triage in Gengo Mar 7, 2024
@spenserblack spenserblack self-assigned this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

1 participant