Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how themes work? #210

Closed
spenserblack opened this issue Dec 5, 2022 · 2 comments
Closed

Refactor how themes work? #210

spenserblack opened this issue Dec 5, 2022 · 2 comments

Comments

@spenserblack
Copy link
Owner

A plugin, currently, would have to pass its theme to each Stat to get proper rendering. Perhaps the theme should be stored in a class variable so that other classes can reference it without having to pass references to the theme everywhere.
@spenserblack
Copy link
Owner Author

Perhaps get_plugin should be renamed to set_plugin which would set an active plugin class variable. Plugin provides theme that everything else references.

@spenserblack spenserblack mentioned this issue Dec 7, 2022
Closed
@spenserblack
Copy link
Owner Author

cc3531b makes it easy to do this in a loop, closing as not planned for now.

@spenserblack spenserblack closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spenserblack