Skip to content

Commit

Permalink
Modify new algorithm service doc (kubeflow#1198)
Browse files Browse the repository at this point in the history
* Add step to new algorithm service doc to modify check Katib ready script

* Add link to script
  • Loading branch information
andreyvelich authored and sperlingxx committed Jun 29, 2020
1 parent ac2681d commit d528a62
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion docs/new-algorithm-service.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,13 @@ To add a e2e test for the new algorithm, in [test/scripts/v1alpha3](../test/scri

2. Create a new script `build-suggestion-xxx.sh` to build new suggestion. Here is an example [test/scripts/v1alpha3/build-suggestion-hyperopt.sh](../test/scripts/v1alpha3/build-suggestion-hyperopt.sh).

3. Create a new script `run-suggestion-xxx.sh` to run new suggestion. Below is an example (Replace `<name>` with the new algorithm name):
3. Update [`check-katib-ready.sh`](../test/scripts/v1alpha3/check-katib-ready.sh) script to modify `katib-config.yaml` with the new test suggestion image name. We use `gcr.io/kubeflow-ci` registry to run presubmit tests. For example (Replace `<name>` with the new suggestion name):

```
sed -i -e "s@gcr.io\/kubeflow-images-public\/katib\/v1alpha3\/suggestion-<name>@${REGISTRY}\/${REPO_NAME}\/v1alpha3\/suggestion-<name>@" manifests/v1alpha3/katib-controller/katib-config.yaml
```

4. Create a new script `run-suggestion-xxx.sh` to run new suggestion. Below is an example (Replace `<name>` with the new algorithm name):

```bash
#!/bin/bash
Expand Down

0 comments on commit d528a62

Please sign in to comment.