Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Subtitle rendering support #69

Open
TS53 opened this issue Oct 29, 2024 · 8 comments
Open

[FEATURE REQUEST] Subtitle rendering support #69

TS53 opened this issue Oct 29, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@TS53
Copy link

TS53 commented Oct 29, 2024

Is your feature request related to a problem? Please describe.
I saw that loading lyrics is already supported, would it be possible to also support subtitle rendering maybe even ASS subtitles, by uploading a subtitle file?

Is your feature related to the sound library or the app/website?
The issue is only related to the app/website.

Describe the solution you'd like

  • A possibility to upload a ASS subtitle together with a MIDI file
  • By default render the ASS subtitle over all other GUI-elements like piano and settings with a library like this one
  • Be able to quit from the subtitles for example with ESC key, if a subtitle covers settings
  • Be able to turn off subtitle rendering even if the subtitle was loaded

Describe alternatives you've considered

  • stay with the lyrics-only method
  • SRT subtitles: less styling support, simpler format

Additional context

  • Rendering subtitles would be dependend on the bpm of the MIDI
  • When a subtitle is given and no midi file, it could be "played" without music. But then a default bpm would be used that could be changed at best.
  • If simple to implement, a subtitle voice waveform could get added whenever a word or a sentence in the subtitle is active (but low priority)
@TS53 TS53 added the enhancement New feature or request label Oct 29, 2024
@spessasus
Copy link
Owner

spessasus commented Oct 29, 2024

Subtitles? What for? What would be the use case for this?

Also, Spessasynth does not load any lyrics externally, they come from the MIDI file.

@TS53
Copy link
Author

TS53 commented Oct 29, 2024

Karaoke support. Since the midi rendering works really good with Spessasynth, subtitle rendering would make it a perfect karaoke tool.

Yeah, I know that it's possible to embed the lyrics into the midi file, but it is less simple to read the lyrics at the expected time.
Thus, my request for the subtitle rendering.

@spessasus
Copy link
Owner

Aren't .kar files used for this? According to my research, .ass is mostly used in videos.

@TS53
Copy link
Author

TS53 commented Oct 29, 2024

As far as I know, ASS subtitles are the way to go. They have specific Karaoke tags, to easily allow making subtitles a perfect fit for karaoke.

It will also include all settings like color, font and position of the subtitle rendering. So, no new GUI settings are required for this.

Other formats like SRT do not have karaoke support.

ASS subtitles would even make rendering of lyrics for choir music (multiple singer voices) possible.

@spessasus
Copy link
Owner

So, no new GUI settings are required for this.

But a completely new system for displaying them is. If I'll ever implement this feature, it will simply allow importing these into the decoded text window.

@spessasus
Copy link
Owner

spessasus commented Oct 29, 2024

And by the way, can you provide some example .ass files to test with?

@TS53
Copy link
Author

TS53 commented Oct 30, 2024

I will add some subtitles.

If I understand correctly, you mean that they would be rendered in the lyrics window? This would probably be a bit small, because I think currently there is no resize possibility of this window.

@TS53
Copy link
Author

TS53 commented Oct 30, 2024

I have now created the files:

  • a MIDI file for three choir voices
  • an ASS subtitle with the three voices for the MIDI file
  • a video as a test comparison to see the expected rendering

Es geht eine dunkle Wolk herein.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants