Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyOnWriteFs.Mkdir/MkdirAll should return os.ErrExist and not syscall.EEXIST #189

Closed
bep opened this issue Dec 15, 2018 · 0 comments
Closed

CopyOnWriteFs.Mkdir/MkdirAll should return os.ErrExist and not syscall.EEXIST #189

bep opened this issue Dec 15, 2018 · 0 comments
Assignees
@bep
Labels
bug

Comments

@bep
Copy link
Collaborator

bep commented Dec 15, 2018

The main reason being that os.IsExist does not return true for syscall.EEXIST for all platforms, see:

https://github.com/golang/go/blob/master/src/os/error_windows.go#L9
@bep bep added the bug label Dec 15, 2018
@bep bep changed the title CopyOnWriteFs.Mkdir/MkdirAll should return os. ErrExist and not syscall.EEXIST CopyOnWriteFs.Mkdir/MkdirAll should return os.ErrExist and not syscall.EEXIST Dec 15, 2018
@bep bep mentioned this issue Dec 15, 2018
Closed
@bep bep self-assigned this Dec 16, 2018
This was referenced Dec 16, 2018
Merged
Closed
@bep bep closed this as completed in 5e9f8ec Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bep bep

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bep