-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doesn't handle named types #165
Comments
Is anyone paying attention to this? I feel like it's a pretty common scenario, and there are also many named types in practical use that cannot be converted at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd expect this test to pass:
The fix is pretty easy. Near the beginning of
ToFloat64E
, just after the call toindirect
, add something like:I'm filing an issue rather than sending a PR because the proper fix applies this to all conversions, not just floats, and that's a pretty substantive change, so I wanted to discuss first.
The text was updated successfully, but these errors were encountered: