Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace errNegativeNotAllowed with overflow error #171

Open
sagikazarmark opened this issue Feb 5, 2023 · 0 comments
Open

Replace errNegativeNotAllowed with overflow error #171

sagikazarmark opened this issue Feb 5, 2023 · 0 comments

Comments

@sagikazarmark
Copy link
Collaborator

Technically, the following is valid:

var i int64 = -1
j := uint64(i)

The value will overflow, but the conversion happens.

We should replace the errNegativeNotAllowed error with one that signals that the conversion was successful, but an overflow occurred.

Combining this idea with #86, it might even make sense to have a single base error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sagikazarmark