Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fish completion error #1246

Closed
matejvasek opened this issue Oct 5, 2020 · 5 comments · Fixed by #1247
Closed

Fish completion error #1246

matejvasek opened this issue Oct 5, 2020 · 5 comments · Fixed by #1247

Comments

@matejvasek
Copy link
Contributor 

Expected a command, but instead found a redirection
complete --do-complete "faas " &> /dev/null

I think it should be:

complete --do-complete "faas " 2> /dev/null
@matejvasek
Copy link
Contributor Author

fish, version 3.0.2

@matejvasek
Copy link
Contributor Author

With 3.1.2 it works well.

@matejvasek
Copy link
Contributor Author

Seems that the &> redirect operator is supported in 3.1 and not in 3.0.

@matejvasek matejvasek mentioned this issue Oct 5, 2020
Merged
@marckhouzam
Copy link
Collaborator

Thanks @matejvasek!
The Fish completion was tested with Fish 3.1.
Does everything else seem to work properly with 3.0?

@matejvasek
Copy link
Contributor Author

matejvasek commented Oct 5, 2020 •
edited
Loading

I gave it just short try, It does complete flags and also their parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fish output redirection matejvasek/cobra
2 participants
@marckhouzam @matejvasek