Feature-Request: Make absURL and relURL accept anything #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Agree. |
| @@ -1803,7 +1803,7 @@ func htmlUnescape(in interface{}) (string, error) { | |||
|
|
|||
| func init() { | |||
| funcMap = template.FuncMap{ | |||
| "absURL": func(a string) template.HTML { return template.HTML(helpers.AbsURL(a)) }, | |||
| "absURL": func(a interface{}) template.HTML { return template.HTML(helpers.AbsURL(cast.ToString(a))) }, | |||
There was a problem hiding this comment.
Please use the ToStringE variant and return any error as second return value from the template func. Same with relURL.
There was a problem hiding this comment.
He learned from the best. 😉 Do the changes in 3a2a4c3 need errors returned, too?
There was a problem hiding this comment.
@moorereason please stick to this PR. Taking the entire commit history of Hugo into consideration for this simple change is ... Not fruitful.
|
We'll handle the errors as part of #2354 |
|
Thanks 😄 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template functions
relURLandabsURLcurrently only accept strings. However, after #889 many template functions likesafeHtmlwere opened to accept more than strings. So I suggest that alsorelURLandabsURLshould share this behavior. For example the following code currently throws an errorbecause
.RSSLinkis of typetemplate.HTML(it throws an error with my versionHugo Static Site Generator v0.16-DEV BuildDate: 2016-02-06T18:14:17+01:00shipped with Ubuntu 16.04).I followed 3a2a4c3 . Note that I never programmed in go before, so someone should check my changings :-) I am also not sure whether code injections are possible after the changes in my commit...