Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My opinion #1059

Closed
yqcs opened this issue Dec 28, 2020 · 2 comments
Closed

My opinion #1059

yqcs opened this issue Dec 28, 2020 · 2 comments
Labels
kind/question A question related to the project

Comments

@yqcs
Copy link

yqcs commented Dec 28, 2020

Why change capital letters to lowercase letters without permission? Comments are also automatically cleared. I think these should be set manually.

@yqcs yqcs added the kind/enhancement New feature or request label Dec 28, 2020
@github-actions
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark sagikazarmark added kind/question A question related to the project and removed kind/enhancement New feature or request labels Dec 28, 2020
@sagikazarmark
Copy link
Collaborator

@yqcs case insensitivity is necessary for merging configuration from various sources (for example env vars are usually upper case). You can track #1014 for this issue.

As for comments: that's an unfortunate consequence of writing config. Actually, the config write feature is not supposed to be used for saving config state. It's useful for features like writing default config.

I'm closing the issue as it's not actually an enhancement or not new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question A question related to the project
Projects
None yet
Development

No branches or pull requests

2 participants