Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable experimental features runtime #1721

Closed
1 task done
sagikazarmark opened this issue Dec 18, 2023 · 2 comments · Fixed by #1854
Closed
1 task done

Enable experimental features runtime #1721

sagikazarmark opened this issue Dec 18, 2023 · 2 comments · Fixed by #1854
Labels
kind/enhancement New feature or request

Comments

@sagikazarmark
Copy link
Collaborator

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

Consumers may want to enable experimental features runtime. Although it may not always be possible, it should be doable for the most part.

Proposed Solution

Introduce a new API to enable feature flags in Viper.

Something like:

v := viper.New(viper.Enable("bind-struct"))

The nice thing about this API is that it's generic and it doesn't necessarily break once an experiment is rolled out as a fully functional feature.

The counterpart of Enable should be Disable, so users can go back to the old behavior while it's still available.

Alternatives Considered

Other potential names:

  • EnableFlag/DisableFlag
  • EnableExperiment/DisableExperiment
  • Enable(Experimental)Feature/Disable(Experimental)Feature

Additional Information

Came up in #1706 (comment)

@sagikazarmark sagikazarmark added the kind/enhancement New feature or request label Dec 18, 2023
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@mazenharake
Copy link

imho, I think I would prefer viper.New(viper.EnableBindStruct(), ...). I would also reckon it is easier to maintain since as more features are released then the viper.Enable("...") could become bloated. Since this is going to become a part of the API then it is clearer to know what Options there are by simply looking at the exported Options rather than to look up a string in the documentation.

just my 2 cents, either would be fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants