-
Notifications
You must be signed in to change notification settings - Fork 2k
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutomaticEnv does not override Unmarshaled config slice values #1732
Comments
👋 Thanks for reporting! A maintainer will take a look at your issue shortly. 👀 In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues. ⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9 📣 If you've already given us your feedback, you can still help by spreading the news, https://twitter.com/sagikazarmark/status/1306904078967074816 Thank you! ❤️ |
Encountering similar issues. The PR looks good! Would love this feature added. |
Preflight Checklist
Viper Version
1.18.2
Go Version
1.21.1
Config Source
Files
Format
YAML
Repl.it link
No response
Code reproducing the issue
Expected Behavior
Initially read a YAML file with
modes
set to{1, 2, 3}
andclients
set to{ name: foo, name: bar }
.I expect
config.Modes
to be[]int{1, 2, 300}
since theMODES_2
environment variable should override3
to300
.Similarly, I expect
config.Clients[1].Name
value to be overridden by theCLIENTS_1_NAME
environment variable frombar
tobaz
.Actual Behavior
The environment variable did not override the unmarshaled config struct.
config.Modes
is still[]int{1, 2, 3}
,and
config.Clients[1].Name
is stillbar
.Steps To Reproduce
1.Run above test
Additional Information
The bug only occurs with slice values, i.e.,
config.Modes
andconfig.Clients[1].Name
. Configurations without slices, i.e.,config.Name
, are still overridden by the env variable.Note that
v.GetInt("modes.2")
andv.GetString("clients.1.name")
work. Only the unmarshaled struct is bugged.No response
The text was updated successfully, but these errors were encountered: