Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server fails in python 3.9 #155

Closed
allemangD opened this issue Apr 15, 2024 · 2 comments
Closed

Server fails in python 3.9 #155

allemangD opened this issue Apr 15, 2024 · 2 comments
Labels

Comments

@allemangD
Copy link

allemangD commented Apr 15, 2024

Since 3a32d1b serving fails due to os.path.realpath receiving unexpected argument strict. This parameter was added in 3.10. I haven't checked if there are other compatibilities issues introduced in that change.

The line is at https://github.com/sphinx-doc/sphinx-autobuild/blob/3a32d1ba/sphinx_autobuild/server.py#L26

@AA-Turner
Copy link
Member

Fixed in #157

@Borda
Copy link
Contributor

Borda commented May 15, 2024

seems the problem is with the Python version; it uses the syntax of py3.10 (see: https://docs.python.org/3.10/library/os.path.html#os.path.realpath), but the package-supported version is 3.9+
https://github.com/Borda/sphinx-autobuild/blob/674264ecf1ea64b8276d80f809cd679150a2646c/pyproject.toml#L16
where the strict is missing https://docs.python.org/3.9/library/os.path.html#os.path.realpath

So we can bump the Python version or not use the strict argument...

It seems there was a fix #157, but was it released?
What I see it is missing in latest 2024.04.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants