Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing-controllers-openapi *-extended* #8

Closed
leonardlin opened this issue Nov 13, 2022 · 9 comments
Closed

routing-controllers-openapi *-extended* #8

leonardlin opened this issue Nov 13, 2022 · 9 comments

Comments

@leonardlin
Copy link

leonardlin commented Nov 13, 2022

This is amazing,
I've been waiting for a replacement because my CI tools to all christmas-tree on routing-controllers.

I am also using "routing-controllers-openapi" which has a peer dependency to routing-controllers@0.9

Are you interested to add these ecosystem libraries too?
I would help you update routing-controllers-openapi-extended to work with your routing-controllers-extended.

I guess a better name is "routing-controllers-extended-openapi"

@spicemc
Copy link
Owner

spicemc commented Nov 13, 2022

Glad you like it.

It's a great idea and "routing-controllers-openapi" is a great project.
Since my bandwidth is limited to handle additional projects we could ask the maintainer to add routing-controllers-extended as a peer dependency?
It seems to be abandoned too so we might be unlucky. Then i would fork and update it with your help. And yes "routing-controllers-extended-openapi" sounds good.

@leonardlin
Copy link
Author

I placed the question: epiphone/routing-controllers-openapi#120

I wait what they say, otherwise we can fork it.

@spicemc
Copy link
Owner

spicemc commented Nov 13, 2022

👍

@leonardlin
Copy link
Author

It's been a week, so I think the project is dead too.
Would you mind to fork it? I would get on updating it asap.

@spicemc
Copy link
Owner

spicemc commented Nov 21, 2022

Sure. It's forked now and i sent an invitation to you.

@spicemc spicemc closed this as completed Nov 21, 2022
@leonardlin
Copy link
Author

Thanks, on it.

@leonardlin
Copy link
Author

@spicemc I think the https://github.com/spicemc/routing-controllers-extended-openapi is ready.

  • tests pass
  • sample updated and tested
  • updated docu

I think next would be to setup publish to npm.
I have never done that and I might not have permissions for that, could I trouble you for that step?

Thanks Leo

@spicemc
Copy link
Owner

spicemc commented Nov 22, 2022

Sure, i`ll take care of this.
Yes, it's not possible to publish without my npm token.

@spicemc
Copy link
Owner

spicemc commented Nov 22, 2022

It's published as 4.0.0 because 1.0.0 already exists.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants