fix(popupLyrics): update view in system tray mode #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lseoksee
changed the title
rxri
approved these changes
Feb 28, 2025
rxri
changed the title
rxri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue where lyrics were not updating when Spotify was in tray mode (minimized).
The callback of the
requestAnimationFrame()function stops working when Spotify is switched to tray mode (minimized), making it impossible to check ifdocument.hiddenis true.Due to the asynchronous nature of the callback, there are cases where
tick()passes through before the callback is interrupted, causingdocument.hiddento return true and allowing lyrics to be updated in tray mode. However, the likelihood of this happening is too low.So, I changed the structure to listen for the
visibilitychangeevent.