Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: the hostRPFilter filed is no take effect #3905

Closed
cyclinder opened this issue Aug 20, 2024 · 0 comments · Fixed by #3906
Closed

coordinator: the hostRPFilter filed is no take effect #3905

cyclinder opened this issue Aug 20, 2024 · 0 comments · Fixed by #3906
Assignees
Labels
kind/bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@cyclinder
Copy link
Collaborator

Spiderpool Version

all

Bug Type

Spiderpool-Controller

Main CNI

all

What happened?

apiVersion: spiderpool.spidernet.io/v2beta1
kind: SpiderMultusConfig
metadata:
  creationTimestamp: "2024-08-20T02:47:30Z"
  generation: 1
  name: test-macvlan1
  namespace: kube-system
  resourceVersion: "1222877"
  uid: 17fbae2a-9699-4eb2-8a8b-c82a8f031248
spec:
  cniType: macvlan
  coordinator:
    detectGateway: false
    detectIPConflict: false
    hostRPFilter: 1
    hostRuleTable: 500
    mode: auto
    podDefaultRouteNIC: ""
    podMACPrefix: ""
    tunePodRoutes: true
    txQueueLen: 0
  disableIPAM: false
  enableCoordinator: true
  macvlan:
    enableRdma: false
    ippools:
      ipv4:
      - vlan100-v4
      ipv6:
      - vlan100-v6
    master:
    - eth0
    rdmaResourceName: ""
    vlanID: 100
apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
  creationTimestamp: "2024-08-20T02:47:30Z"
  generation: 1
  name: test-macvlan1
  namespace: kube-system
  ownerReferences:
  - apiVersion: spiderpool.spidernet.io/v2beta1
    blockOwnerDeletion: true
    controller: true
    kind: SpiderMultusConfig
    name: test-macvlan1
    uid: 17fbae2a-9699-4eb2-8a8b-c82a8f031248
  resourceVersion: "1222878"
  uid: e9641175-ae87-406e-80a9-124d9ad66ec3
spec:
  config: '{"cniVersion":"0.3.1","name":"test-macvlan1","plugins":[{"vlanID":100,"type":"ifacer","interfaces":["eth0"]},{"type":"macvlan","master":"eth0.100","mode":"bridge","ipam":{"type":"spiderpool","default_ipv4_ippool":["vlan100-v4"],"default_ipv6_ippool":["vlan100-v6"]}},{"txQueueLen":0,"detectIPConflict":false,"detectGateway":false,"tunePodRoutes":true,"mode":"auto","type":"coordinator"}]}'

What did you expect to happen?

  • change hostRPFilter to podRPFilter, the hostRPFilter should be configured by spiderpool-agent, this has been done in agent set rp_filter to 0 for the each node #3898.
  • Fix the hostRPFilter of spidermultuisconfig can't covert to multus NAD correctly.

How to reproduce it (as minimally and precisely as possible)

create a spidermultusconfig with configure hostRPFilter.

Additional Context

No response

@cyclinder cyclinder self-assigned this Aug 20, 2024
@ty-dc ty-dc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants