Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin should not be able to create two policies with the same name #79

Open
v0lkan opened this issue Jan 10, 2025 · 3 comments
Open

Admin should not be able to create two policies with the same name #79

v0lkan opened this issue Jan 10, 2025 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@v0lkan
Copy link
Contributor

v0lkan commented Jan 10, 2025

Currently it's possible to create two policies with the same name.

When that's done they will have different ids; so they will be distinct policies, but their name will be the same.

That's rather confusing for the end user and could even result in misconfigurations.

It's better to make the policy name unique (both in code, and also a unique constraint in sqlite too)

@v0lkan v0lkan added bug Something isn't working good first issue Good for newcomers labels Jan 10, 2025
@yasinterol
Copy link
Contributor

Hey, Hope your are doing well 🙏 Can you assign me ?

@v0lkan
Copy link
Contributor Author

v0lkan commented Feb 6, 2025

Hey Yasin,

All going well, thanks— Chaotic… but good :) .
Hope you are doing well too.

Let me check if the policy engine is still working :) (last time it was overly-agressive and failing on some edge case) - if that part is sorted, I'll assign this to you.

Thanks for your interest 🙏 .

@v0lkan
Copy link
Contributor Author

v0lkan commented Feb 7, 2025

@yasinterol all yours.

if you need help, you know where to find me :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants