Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding support for specifying a cert and a key manually for federation endpoint. #2202

Closed
caleygoff-invitae opened this issue Apr 8, 2021 · 4 comments · Fixed by #5163
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@caleygoff-invitae
Copy link

caleygoff-invitae commented Apr 8, 2021

Essentially this is a request to add the ability to specify a cert bundle, a cert and a key, for the federation endpoint to use and present for consumers/clients that want to interact with the endpoint.

By allowing for manually providing this information, it would allow for thirdparty maintainers such as cert-manager to manage the bundle as a secret and then the spire federation endpoint can import that bundle. This would remove the hard dependency on acme and using the web_pki.

A reason perhaps one would want to use something like cert-manager to manage their bundle is that they have gone through the effort in adding features that allow for little trickeries for various scenarios. Currently I have a scenario in which cert-manager allows for me to use the dns-01 type to register my certs using LetsEncrypt as the Cert-Manager backend. Essentially doing what autocert is doing by only that autocert seems only allow for the http-01 type, in which for me in my specific use case causes web_pki to eventually fail.

@caleygoff-invitae caleygoff-invitae changed the title Consider adding support for passing a bundle in manually for federation endpoint. Consider adding support for specifying a cert and a key manually for federation endpoint. Apr 8, 2021
@azdagron
Copy link
Member

@evan2645 has volunteered to scope this out.

@evan2645
Copy link
Member

We have recently agreed on how to configure this on the OIDC provider, and I think we can use the same approach here.

Introduce a new serving_cert_file config section to be mutually exclusive with the acme section. Same naming etc as referenced above, and also logging a warning when set. There should have logic to update the bundle endpoint TLS stack if the file data changes without restarting SPIRE Server. Similar to that issue, moving this one to backlog and help wanted.

@evan2645 evan2645 added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Feb 16, 2023
@evan2645 evan2645 removed their assignment Feb 16, 2023
@haithamshahin333
Copy link

Hello team, any update on this? I'm trying to confirm that the latest release of Spire Server does not yet support bring-your-own-cert for the Federation Endpoint. If https_web is used, one must us ACME, correct?

@amartinezfayo
Copy link
Member

Hi @haithamshahin333, thank you for reaching out. This is still a planned feature that has not been implemented yet. If the https_web profile is used to serve the bundle endpoint, ACME must be used as there is no other option yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants