Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Httpchallenge agent plugin config improvement. #5427

Open
edwbuck opened this issue Aug 26, 2024 · 0 comments
Open

Httpchallenge agent plugin config improvement. #5427

edwbuck opened this issue Aug 26, 2024 · 0 comments
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@edwbuck
Copy link
Contributor

edwbuck commented Aug 26, 2024

The Httpchallenge agent plugin opens a temporary web server to receive the response of the httpchallenge server plugin. This temporary web server can be launched in one of two configurations:

  1. Normal operation - the web server binds to all hostnames.
  2. Unit testing operation - the web server binds to a configurable hostname.

The Unit testing operation was added specifically due to the need to avoid all hostnames in our build system under CircleCI, where we override the listening port to bind to localhost.

A few small opportunities for improvement exist:

  • Promoting the ability to bind to a specific hostname to the plugin's runtime configuration
  • Replacing the "side door" logic for overriding the listening hostname in unit tests with the feature to specify it in the configuration suggested here.
@spiffe spiffe deleted a comment Aug 26, 2024
@spiffe spiffe deleted a comment from rphmauriciodev Aug 26, 2024
@amartinezfayo amartinezfayo added triage/in-progress Issue triage is in progress priority/backlog Issue is approved and in the backlog help wanted Issues with this label are ready to start work but are in need of someone to do it and removed triage/in-progress Issue triage is in progress labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

3 participants
@edwbuck @amartinezfayo and others