Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve agent plugin nodeattestore x509pop's configuration handling #5513

Open
edwbuck opened this issue Sep 23, 2024 · 0 comments
Open

Improve agent plugin nodeattestore x509pop's configuration handling #5513

edwbuck opened this issue Sep 23, 2024 · 0 comments
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@edwbuck
Copy link
Contributor

edwbuck commented Sep 23, 2024

The x509pop agent plugin has a few key configuration items, but unlike a number of the other plugins, these configuration items seem to be validated in an intertwined way, with some of the validation logic being embedded in loadConfigData(...) which should be responsible for loading the data, not loading the data and also raising errors about the config.

This issue is to track the work specific to x509pop, which was deemed necessary (an a bit out of scope) during the work of #5303 which covers a broader effort of establishing a Validation interface in the plugins.

@azdagron azdagron added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

2 participants