-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better inner loop experience for blocked HTTP hosts #1090
Comments
I'm afraid I don't have an additional approach to add, but I think I'd vote for option 1 above (though in addition to sending the DestinationNotAllowed error to the application -- but perhaps this was intended to remain anyways). I'm less keen on interactive scenarios... and unless there are other items we can already think of to go into a potential 'after-action report', it might be a bit early to add one at this stage. |
I think an option would be to update the |
Decision was for "Bypass the normal logging and print a message directly to stderr, stating the component and host, and pointing them to |
If Spin blocks an outbound HTTP request for not being on the allow list, it writes an
info
log, which nobody sees, and returns a DestinationNotAllowed error to the application, which the application probably buries in its log.However, in the inner dev loop, the likely cause of this is that the user has forgotten to add the host to the component's allow list. It would be good if, in the local dev experience (in the terminal and running from a
spin.toml
file), we could provide users more specific and actionable feedback. Some possible ideas:allowed_http_hosts
- natural but risks getting lost in spewAny other offers?
The text was updated successfully, but these errors were encountered: