You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem: We run crd-reference/generate.sh in CI but it doesn't actually do anything because it isn't placing the generate files in the right location. This means that if we don't update the references they fall out of date.
Potential solution: Fix the script to actually place the files in the correct location. This has the downside that it will overwrite the aliases field in the front matter and I don't see a way with Crdoc to insert that. We'd have to write some sed or awk to do that for us.
The text was updated successfully, but these errors were encountered:
@bacongobbler how important is it that we keep the aliases on the CRD reference docs? If we could do away with that requirement than fixing this would be fairly straightforward.
I'm not too concerned as long as nobody is currently referencing those aliases in other locations. Those aliases were put in place after spinkube/spin-operator#279 was raised
Sweet, more broadly does that mean we don't need those aliases anywhere in the codebase? Because maybe that could be another issue to remove the aliases which would simplify the codebase.
Problem: We run
crd-reference/generate.sh
in CI but it doesn't actually do anything because it isn't placing the generate files in the right location. This means that if we don't update the references they fall out of date.Potential solution: Fix the script to actually place the files in the correct location. This has the downside that it will overwrite the aliases field in the front matter and I don't see a way with Crdoc to insert that. We'd have to write some sed or awk to do that for us.
The text was updated successfully, but these errors were encountered: