Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to configure OTel parameters for their excecutor #253

Closed
calebschoepp opened this issue Jun 14, 2024 · 5 comments
Closed

Allow users to configure OTel parameters for their excecutor #253

calebschoepp opened this issue Jun 14, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@calebschoepp
Copy link
Contributor

Users need to be able to set OTel parameters like OTEL_EXPORTER_OTLP_ENDPOINT on their chosen executor to enable o11y.

@calebschoepp
Copy link
Contributor Author

Relevant design work is being tracked here.

@calebschoepp
Copy link
Contributor Author

Talking through this with Michelle we decided it makes sense to define OTEL parameters on the SpinAppExecutor, but that it probably makes sense to hold off on defining OTEL parameters on the SpinApp (not all executors would be able to support setting it at the app level and we also don't want to pull too many infra concerns into the app CR). We also think that the OTEL values should be scoped under the deployment config since they only work for sure with the shim executor.

We'll allow list the OTEL values in the operator so that arbitrary environment variables can't be injected. Here's an example of the schema.

apiVersion: [core.spinoperator.dev/v1alpha1](http://core.spinoperator.dev/v1alpha1)
kind: SpinAppExecutor
metadata:
  name: containerd-shim-spin
spec:
  createDeployment: true
  deploymentConfig:
    runtimeClassName: wasmtime-spin-v2
    installDefaultCACerts: true
    otel: map[string, string]

@michelleN michelleN added the enhancement New feature or request label Jul 10, 2024
@calebschoepp
Copy link
Contributor Author

#273 is related.

@calebschoepp
Copy link
Contributor Author

@asteurer is working on this

@calebschoepp
Copy link
Contributor Author

Closed by #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants