Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconventional signature for Iterator.Next(). #298

Open
purplefox opened this issue Oct 5, 2024 · 0 comments
Open

Unconventional signature for Iterator.Next(). #298

purplefox opened this issue Oct 5, 2024 · 0 comments
Labels
good first issue Good for newcomers
Milestone
1.0

Comments

@purplefox
Copy link
Contributor

iteration.Iterator.Next() currently has the signature Next() (bool, common.KV, error). We should change it to Next() (common.KV, bool, error) to be more consistent with golang convention.
@purplefox purplefox added this to the 1.0 milestone Oct 5, 2024
@stanislavkozlovski stanislavkozlovski added the good first issue Good for newcomers label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@purplefox @stanislavkozlovski