Skip to content

Commit c059ec6

Browse files
refactor: move startingUp flag update after store in mySegmentsUpdater
1 parent c09f14d commit c059ec6

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

src/storages/inLocalStorage/MySegmentsCacheInLocal.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,4 @@ export class MySegmentsCacheInLocal extends AbstractMySegmentsCacheSync {
7171
return n;
7272
}
7373

74-
resetSegments(segmentsData: MySegmentsData | IMySegmentsResponse) {
75-
try {
76-
return super.resetSegments(segmentsData);
77-
} catch (e) {
78-
this.log.error(LOG_PREFIX + e);
79-
return false;
80-
}
81-
}
82-
8374
}

src/sync/polling/updaters/mySegmentsUpdater.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@ export function mySegmentsUpdaterFactory(
6666
new Promise((res) => { updateSegments(segmentsData); res(true); }) :
6767
// If not provided, fetch mySegments
6868
mySegmentsFetcher(matchingKey, noCache, till, _promiseDecorator).then(segments => {
69-
// Only when we have downloaded segments completely, we should not keep retrying anymore
70-
startingUp = false;
71-
7269
updateSegments(segments);
70+
71+
// Only when we have downloaded and stored segments completely, we should not keep retrying anymore
72+
startingUp = false;
7373
return true;
7474
});
7575

0 commit comments

Comments
 (0)