Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable the key (legend) #165

Closed
tradiff opened this issue Dec 20, 2022 · 2 comments · Fixed by #166
Closed

Option to disable the key (legend) #165

tradiff opened this issue Dec 20, 2022 · 2 comments · Fixed by #166

Comments

@tradiff
Copy link
Contributor

tradiff commented Dec 20, 2022

Love the gem! Is there a way to disable the key? It becomes noise after a while once the user has learned the colors and symbols. If there is not currently a way to do this, would you be open to a PR to add this configuration?
@mcmire
Copy link
Collaborator

mcmire commented Dec 20, 2022

There is not currently a way to disable the key, but yes, I would be open to a PR!

@tradiff
Copy link
Contributor Author

tradiff commented Dec 22, 2022

@mcmire I have the feature added, but I'm not sure where I should add specs for the new behavior. Do you have any suggestions on that? Here's my branch if you're interested in a sneak peek.

@tradiff tradiff mentioned this issue Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Option to disable the key tradiff/super_diff
2 participants
@mcmire @tradiff