Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Formats #16

Open
cdharrison opened this issue Aug 19, 2011 · 4 comments
Open

Post Formats #16

cdharrison opened this issue Aug 19, 2011 · 4 comments
Labels

Comments

@cdharrison
Copy link
Collaborator

The latest updates added support for WordPress Post Formats. I made a change to simple_post_class to add a class to help target these alternate formats... Previous, "hentry" is the only class we forced. Now if it's a standard post format, it stays "hentry". Otherwise, it'll get a class such as "hentry post-aside" where 'post' will change depending on the Post Type, and 'aside' would reflect whatever the Post Format is set to.

I hate adding extra classes given our goals with this theme, but thought in this case these would help with stylizing the alternate post formats...

For or against this change? Prefer we do it differently? Let me know.

@cdharrison
Copy link
Collaborator Author

These are the different types of Post Formats that are supported: 'aside', 'gallery', 'link', 'image', 'quote', 'status', 'video', 'audio', 'chat'

@splorp
Copy link
Owner

splorp commented Aug 19, 2011

Let me think about this a bit. I’m not opposed to the implementation, but in my mind, it’s not clean enough. That said, I have no idea how else we would handle styling of the different post formats. Or maybe that’s the point of Tersus … we simply don’t handle the styling.

@cdharrison
Copy link
Collaborator Author

Bump. I did recently add something to Advanced Layout that would give asides a slightly different appearance (e.g. not displaying post meta). Let me know what you think about the change. I can roll it back if needed.

@splorp
Copy link
Owner

splorp commented Dec 23, 2011

It gives us a good start on tinkering with this. Personally, I don’t use post formats at all … but that my certainly change down the road. It‘s a powerful feature that the theme should definitely support.

At some point, I’d like to revisit at the post type class names, as they could maybe benefit from some tidying up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants