Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Formatting #5

Open
danrubin opened this issue May 29, 2010 · 4 comments
Open

Source Formatting #5

danrubin opened this issue May 29, 2010 · 4 comments
Labels

Comments

@danrubin
Copy link
Collaborator

Just adding this to my list of things to review — I'm a big fan of "view source" looking nice with all the proper levels of indentation, so the output/hierarchy is easier to understand. Might be worth including that, plus a few more instructional comments to inform new users about things like hentry, various classes, why a DIV is used vs. some other element, comments at the top and bottom of every included file, etc.

@splorp
Copy link
Owner

splorp commented May 29, 2010

I like teh pretty too.

@cdharrison
Copy link
Collaborator

Most of the source code is formatted pretty well, but could use some touch-up here and there. Inline documentation would be a great idea. Educating users about why things were done a certain way would make this theme an incredible resource.

@danrubin
Copy link
Collaborator Author

I'm not too familiar with how WordPress/PHP handles line endings/tabs, but that's about all I was thinking of cleaning up.

The comments, however, would indeed make this theme (and the others in concert) very useful.

@splorp
Copy link
Owner

splorp commented May 31, 2010

Line endings are generally reliant on the text editor being used and the default format that files are saved in. I’m using BBEdit with all files defaulting to UTF-8 (no BOM) with Unix endings (LF).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants