-
Notifications
You must be signed in to change notification settings - Fork 5
fix: wfe tests run on splunk latest #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9214808
to
fd08c9e
Compare
61cc6aa
to
428d784
Compare
@@ -53,6 +53,11 @@ on: | |||
type: string | |||
default: >- | |||
["latest"] | |||
wfe-run-on-splunk-latest: | |||
required: false | |||
description: "Forces WFE tests to run only on the latest Splunk when set to true. When not set - default behavior." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust description to current usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
wfe_run_on_splunk_latest="${{ !((github.base_ref == 'main' || github.ref_name == 'main') || ((github.base_ref == 'develop' || github.ref_name == 'develop') && github.event_name == 'push')) || github.event_name == 'schedule' }}" | ||
else | ||
wfe_run_on_splunk_latest="${{ inputs.wfe-run-on-splunk-latest }}" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optionally consider having:
wfe_run_on_splunk_all: ${{ (github.event_name == 'push' && (github.ref_name == 'main' || github.ref_name == 'develop')) || (github.event_name == 'pull_request' && github.base_ref == 'main') }}
wfe_run_on_splunk_latest: ${{ github.event_name == 'schedule' || !(wfe_run_on_splunk_all) }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ thats invalid code. My bash version did not look better :)
@dkvashninsplunk I am changing PR title to |
9fdb0e5
to
fc07f5b
Compare
f009d56
to
540338c
Compare
540338c
to
f1ab1dd
Compare
Co-authored-by: mkolasinski-splunk <105011638+mkolasinski-splunk@users.noreply.github.com>
🎉 This PR is included in version 4.19.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Allow for TA to specify Splunk Latest as the only version to run WFE tests against.
It is too expensive to run all WFE tests on all supported Splunk versions on every commit in CDC add-ons on every commit / PR. Let TA to specify the condition to run WFE tests on latest only.
Proposal
Default condition - Run WFE tests on all Splunk Versions for conditions:
Run only on Splunk latest when:
Introduce
wfe-run-on-splunk-latest
input for TA to be precise when it needs a custom rule to run or not run on latest+Fix
Summary of Versions Used
should take its value fromsteps.determine_splunk.outputs.matrixSplunk
Checklist
README.md
has been updated or is not requiredTesting done
(for each selected checkbox, the corresponding test results link should be listed here)