Skip to content

fix: wfe tests run on splunk latest #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

dkvashninsplunk
Copy link
Contributor

@dkvashninsplunk dkvashninsplunk commented Feb 20, 2025

Description

Allow for TA to specify Splunk Latest as the only version to run WFE tests against.

It is too expensive to run all WFE tests on all supported Splunk versions on every commit in CDC add-ons on every commit / PR. Let TA to specify the condition to run WFE tests on latest only.

Proposal

Default condition - Run WFE tests on all Splunk Versions for conditions:

  • push to main, develop
  • PR to main

Run only on Splunk latest when:

  • scheduled execution
  • Everything else

Introduce wfe-run-on-splunk-latest input for TA to be precise when it needs a custom rule to run or not run on latest

+Fix

Summary of Versions Used should take its value from steps.determine_splunk.outputs.matrixSplunk

Checklist

  • README.md has been updated or is not required
  • push trigger tests
  • manual release test
  • automated releases test
  • pull request trigger tests
  • schedule trigger tests
  • workflow errors/warnings reviewed and addressed

Testing done

(for each selected checkbox, the corresponding test results link should be listed here)

@dkvashninsplunk dkvashninsplunk force-pushed the feat/wfe-tests-run-on-splunk-latest branch 3 times, most recently from 9214808 to fd08c9e Compare February 24, 2025 15:30
@dkvashninsplunk dkvashninsplunk marked this pull request as ready for review February 24, 2025 15:39
@dkvashninsplunk dkvashninsplunk requested a review from a team as a code owner February 24, 2025 15:39
@dkvashninsplunk dkvashninsplunk force-pushed the feat/wfe-tests-run-on-splunk-latest branch 12 times, most recently from 61cc6aa to 428d784 Compare February 26, 2025 11:35
@@ -53,6 +53,11 @@ on:
type: string
default: >-
["latest"]
wfe-run-on-splunk-latest:
required: false
description: "Forces WFE tests to run only on the latest Splunk when set to true. When not set - default behavior."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust description to current usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

wfe_run_on_splunk_latest="${{ !((github.base_ref == 'main' || github.ref_name == 'main') || ((github.base_ref == 'develop' || github.ref_name == 'develop') && github.event_name == 'push')) || github.event_name == 'schedule' }}"
else
wfe_run_on_splunk_latest="${{ inputs.wfe-run-on-splunk-latest }}"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally consider having:

wfe_run_on_splunk_all: ${{ (github.event_name == 'push' && (github.ref_name == 'main' || github.ref_name == 'develop')) || (github.event_name == 'pull_request' && github.base_ref == 'main') }}

wfe_run_on_splunk_latest: ${{ github.event_name == 'schedule' || !(wfe_run_on_splunk_all) }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ thats invalid code. My bash version did not look better :)

@mkolasinski-splunk
Copy link
Contributor

@dkvashninsplunk I am changing PR title to fix to be inline with development flow on the repo. Also changing base branch to develop.

@mkolasinski-splunk mkolasinski-splunk changed the base branch from main to develop February 26, 2025 15:40
@mkolasinski-splunk mkolasinski-splunk changed the title feat: wfe tests run on splunk latest fix: wfe tests run on splunk latest Feb 26, 2025
@dkvashninsplunk dkvashninsplunk force-pushed the feat/wfe-tests-run-on-splunk-latest branch 8 times, most recently from 9fdb0e5 to fc07f5b Compare February 27, 2025 09:20
@dkvashninsplunk dkvashninsplunk force-pushed the feat/wfe-tests-run-on-splunk-latest branch 4 times, most recently from f009d56 to 540338c Compare February 27, 2025 10:30
@dkvashninsplunk dkvashninsplunk force-pushed the feat/wfe-tests-run-on-splunk-latest branch from 540338c to f1ab1dd Compare February 27, 2025 11:19
Co-authored-by: mkolasinski-splunk <105011638+mkolasinski-splunk@users.noreply.github.com>
@dkvashninsplunk dkvashninsplunk merged commit 9c42e42 into develop Feb 27, 2025
6 checks passed
@dkvashninsplunk dkvashninsplunk deleted the feat/wfe-tests-run-on-splunk-latest branch February 27, 2025 13:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.19.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants