Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hec.enable should be check prior to include tasks #835

Open
BigCaber opened this issue May 14, 2024 · 1 comment
Open

hec.enable should be check prior to include tasks #835

BigCaber opened this issue May 14, 2024 · 1 comment

Comments

@BigCaber
Copy link

BigCaber commented May 14, 2024

Hi !

https://github.com/splunk/splunk-ansible/blame/e436c07777c3cfb05f1466d0e18a3828bef6e115/roles/splunk_standalone/tasks/main.yml#L2

should have implemented checks like this previous commit affecting the same file.

https://github.com/splunk/splunk-ansible/blame/eb96be01374b0a87ac01e7cbca6eba72222d830b/roles/splunk_standalone/tasks/main.yml#L4

and it should be implemented for all 4 references:

  • splunk-ansible/roles/splunk_heavy_forwarder/tasks/main.yml
  • splunk-ansible/roles/splunk_indexer/tasks/main.yml
  • splunk-ansible/roles/splunk_standalone/tasks/main.yml
  • splunk-ansible/roles/splunk_universal_forwarder/tasks/main.yml

right now, hec tasks run no matter what and there is no way to skip that task, I do not understand why would anyone remove a check..

@BigCaber
Copy link
Author

I forked since it does not allow me to create a branch myself, then added the commit, for reference

0f4cc8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant