Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error messages & visibility #15

Closed
spluxx opened this issue Apr 24, 2020 · 0 comments
Closed

Improved error messages & visibility #15

spluxx opened this issue Apr 24, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@spluxx
Copy link
Owner

spluxx commented Apr 24, 2020

Suggested by @DoneSpeak #13

Errors like index out of range: 128 + 10 > 128 is somewhat cryptic, but it seems like the main library considers it sufficient. protobufjs/protobuf.js#691 (comment)

In a high-level view, the protobuf-related logic consists of 4 components.

  1. parsing .proto files
  2. binary <-> object
  3. object <-> view model
  4. view model <-> view

1 and 2 are done through protobufjs, so I think we can just build a lightweight module that takes in a protobufjs error and returns a more friendly error.

3, if it fails for some unexpected reason, we should still display the object rather than just giving up, so that the users can debug the issue.

@spluxx spluxx added the enhancement New feature or request label Apr 24, 2020
@spluxx spluxx mentioned this issue May 3, 2020
@spluxx spluxx closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant