Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflux.connect and multiple stores #142

Closed
andreypopp opened this issue Nov 26, 2014 · 4 comments
Closed

Reflux.connect and multiple stores #142

andreypopp opened this issue Nov 26, 2014 · 4 comments
Labels
bug
Milestone
0.2.1

Comments

@andreypopp
Copy link

Currently when I use Reflux.connect several times for a single React component with different stores I get a warning:

 Component using Reflux.connect already had property 'hasListener'. Either you had your own property with that name which was now overridden, or you combined connect with ListenerMixin which is unnecessary as connect will include the ListenerMixin methods automatically.

I think this is valid use case and so warnings are unnecessary.
@spoike spoike added the bug label Nov 26, 2014
@spoike
Copy link
Member

spoike commented Nov 26, 2014

Yeah, this is a bug. Nice catch.

@krawaller krawaller mentioned this issue Nov 26, 2014
Merged
@krawaller
Copy link
Contributor

Doh, my bad, sorry! Silly mistake on my part. Opened PR #143 to remove the warning altogether.

@spoike spoike added this to the 0.2.1 milestone Nov 27, 2014
@spoike spoike mentioned this issue Dec 2, 2014
Closed
@bsingr
Copy link

bsingr commented Dec 4, 2014

Thanks!

@spoike
Copy link
Member

spoike commented Dec 7, 2014

The fix (in #143) is in 0.2.1 release.

@spoike spoike closed this as completed Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.2.1
Development

No branches or pull requests
4 participants
@spoike @andreypopp @bsingr @krawaller