Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected identifier in IE8 #202

Closed
Nevon opened this issue Jan 24, 2015 · 3 comments
Closed

Expected identifier in IE8 #202

Nevon opened this issue Jan 24, 2015 · 3 comments
Milestone
0.2.4

Comments

@Nevon
Copy link

Nevon commented Jan 24, 2015

IE8 chokes on something in PublisherMethods.js, giving a SCRIPT1010: expected identifier error. Unfortunately, webpack puts the entire module in a single line string, so I don't know where the problem is. I thought it would be a trailing comma, but as I don't see one, I would assume that some property is a reserved word in ie8.
@Nevon Nevon mentioned this issue Jan 24, 2015
Closed
@srph
Copy link
Contributor

srph commented Jan 25, 2015

Probably ['catch'] as you referenced. But I'm sure this was pull requested before #187

@Nevon
Copy link
Author

Nevon commented Jan 25, 2015

Oh, yeah I didn't see that pull request when I made mine. The usage of catch is indeed the only thing that's preventing Reflux from working in IE8. Once #187 is merged, this can be closed.

@spoike spoike added this to the 0.2.4 milestone Jan 25, 2015
@spoike
Copy link
Member

spoike commented Jan 25, 2015

#187 is merged since it has a comment explaining the bracket notation. Closing this. Thanks for your contribution.

@spoike spoike closed this as completed Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.4
Development

Successfully merging a pull request may close this issue.

Fix IE8 compatibility
3 participants
@spoike @Nevon @srph