fix(android): add proxies for real playback listeners #90
Conversation
space-pope
left a comment
space-pope
left a comment
There was a problem hiding this comment.
LGTM from a code perspective, though see my question below.
| } | ||
| TTSEvent.Type.PLAYBACK_COMPLETE -> { | ||
| // Playback is not pause-able in iOS | ||
| // so this event does not exist there. |
There was a problem hiding this comment.
I wonder about the semantics of the events here. Can playback not be interrupted on iOS by the system giving audio focus to another app (e.g. the phone)?
In my mind, if playback can't be paused on iOS, it would be the PLAYBACK_STOPPED event that doesn't exist there, not PLAYBACK_COMPLETE.
There was a problem hiding this comment.
Can playback not be interrupted on iOS by the system giving audio focus to another app (e.g. the phone)?
Only if that app took over the audio session. Audio can keep playing in the background as well if the user sets the right category and category options, since AudioSession handling is left to the user. While that is something we can know, it is not something currently tracked with an event. But you may be right that the iOS event is more like stopped than complete.
This sends the
playevent based onPLAYBACK_STARTEDandPLAYBACK_STOPPED.