This repository was archived by the owner on May 6, 2022. It is now read-only.
fix(nlu): update NLU slot type to be a map with custom property names #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The NLU slot type was changed in version 5.0. This commit changes it back to what it was pre-5.0. slots will be a map, and the property names will be derived from the name given in the NLU metadata.
space-pope
reviewed
Jan 7, 2021
Contributor
space-pope
left a comment
space-pope
left a comment
There was a problem hiding this comment.
Nice work; just have one question about the typing of value. The RN type declares it to be a string, but the Android code retains the Java type (as much as possible, at least). The latter approach would make RN behave most like the native APIs.
Member
Author
|
In case there was any confusion, edits to the API docs in the README should mainly be done in types.ts rather than in the README itself as the README is generated from the types. |
Contributor
|
I thought it was autogenerated but forgot to track down the origin while I was reading (despite it being listed right in the file...) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The NLU slot type was changed in version 5.0. This commit changes
it back to what it was pre-5.0. slots will be a map, and the property names will
be derived from the name given in the NLU metadata.
This also adds Minecraft NLU to the example app.