Copy binary to PATH #155
Merged
Copy binary to PATH #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nirum` couldn't be executed because nirum binary didn't be placed on `PATH`. so use `--copy-bins` option to copy binary into `PATH`
Kroisse
reviewed
Jul 25, 2017
@Kroisse 좋은 생각인데 현재는 Docker Hub에서 제공하는 automated build로 굽고 있어서 Travis CI에서 테스트하기에는 순서가 애매하긴 할 것 같아요. |
dahlia
approved these changes
Jul 25, 2017
|
아.. 그래서 도커허브에 올리는 부분이 안보였군요ㅜㅜ 일단 이건 머지하고 도커이미지로 테스트하는건 따로 해보겠습니다. |
|
넵넵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nirumcouldn't be executed because nirum binary didn't be placed onPATH. so i added--copy-binsoption to copy binary intoPATH@dahlia @Kroisse @AiOO @ipdae help me!