Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making client class under its service interface namespace #167

Closed
kanghyojun opened this issue Aug 15, 2017 · 0 comments
Closed

Making client class under its service interface namespace #167

kanghyojun opened this issue Aug 15, 2017 · 0 comments
Assignees
Labels
cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) typ:enhance Type: Enhancement/new feature

Comments

@kanghyojun
Copy link
Member

The compiler currently generates a pair of an interface and its client class for each service e.g.:

class FooService(Service):
    ...

class FooService_Client(FooService):
    ...

Making client classes under their interface namespace would be better for avoiding namespace pollution e.g.:

class FooService(Service):
    ...

class FooService_Client(FooService):
    ...

FooService.Client = FooService_Client
@dahlia dahlia added typ:enhance Type: Enhancement/new feature cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) labels Aug 26, 2017
qria added a commit to qria/nirum that referenced this issue Feb 9, 2018
qria added a commit to qria/nirum that referenced this issue Feb 9, 2018
qria added a commit to qria/nirum that referenced this issue Feb 9, 2018
qria added a commit to qria/nirum that referenced this issue Feb 9, 2018
qria added a commit to qria/nirum that referenced this issue Feb 10, 2018
dahlia added a commit that referenced this issue Feb 10, 2018
#167: Add Client class under Service class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) typ:enhance Type: Enhancement/new feature
Projects
None yet
Development

No branches or pull requests

3 participants