Fix the way to mangle temporary local variables used by serializers #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
added
cmp:compiler
Kroisse
previously approved these changes
Dec 21, 2017
dahlia
force-pushed
the
fix-temp-var-mangling
branch
from
3cd8d36 to
a294f5b
Compare
Kroisse
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated serializers had to generated temporary local variables and referred to it, but sometimes these had had an invalid name (e.g.,
__self.field_name__elem__). This patch fixes the bug besides the following bugs:A bug that map types had been serialized in JSON to
{k: v}while these should be[{"key": k, "value": v}].A potential bug that temporary variables had been leaked to their outer scope in Python 2 since local variables in list comprehensions aren't isolated in Python 2. See also What's New in Python 3.0: