#167: Add Client class under Service class #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanghyojun
previously approved these changes
Feb 9, 2018
dahlia
requested changes
Feb 9, 2018
src/Nirum/Targets/Python.hs
Outdated
| if hasattr({className}.Client, '__qualname__'): | ||
| {className}.Client.__qualname__ = '{className}.Client' | ||
| else: | ||
| {className}.Client.__name__ = '{className}.Client' |
There was a problem hiding this comment.
이건 안 해주셔도 될 것 같습니다. 어차피 파이썬 2에서 inner class에 대해서 이런 걸 해주지 않아서…
그냥 파이썬 2에서도 __qualname__ 세팅해주면 될 것 같습니다. 파이썬 2에서는 있어도 무시하기 때문에 어떻게 하든 같은 거라서요.
test/python/service_test.py
Outdated
|
|
||
| def test_service_client_representation(): | ||
| assert repr(SampleService.Client) == \ | ||
| "<class 'fixture.foo.SampleService.Client'>" |
There was a problem hiding this comment.
이거 진짜 그냥 __qualname__만 검사해도 될 것 같아요.
|
@dahlia 반0하였습니다 |
dahlia
requested changes
Feb 9, 2018
src/Nirum/Targets/Python.hs
Outdated
| if hasattr({className}.Client, '__qualname__'): | ||
| {className}.Client.__qualname__ = '{className}.Client' | ||
| else: | ||
| {className}.Client.__name__ = 'Client' |
There was a problem hiding this comment.
파이썬 3에서도 __name__은 'Client'여야 하지 않을까요?
dahlia
added
typ:enhance
dahlia
approved these changes
Feb 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167