-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime free deserializers #272
Merged
kanghyojun
merged 12 commits into
nirum-lang:master
from
dahlia:runtime-free-deserializers
May 16, 2018
Merged
Runtime free deserializers #272
kanghyojun
merged 12 commits into
nirum-lang:master
from
dahlia:runtime-free-deserializers
May 16, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's quite commonly used
Wrote a unit test for it too.
Wrote a unit test for it too.
dahlia
added
typ:bug
Type: Bug/defect
typ:enhance
Type: Enhancement/new feature
typ:refactor
Type: Refactoring (i.e., the same feature to end users but its internal change)
cmp:compiler
Component: Compiler backend (e.g., annotation processors, code generators)
target:python
labels
May 14, 2018
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 76.08% 77.34% +1.26%
==========================================
Files 33 34 +1
Lines 2467 2671 +204
Branches 132 142 +10
==========================================
+ Hits 1877 2066 +189
- Misses 458 463 +5
- Partials 132 142 +10
Continue to review full report at Codecov.
|
kanghyojun
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmp:compiler
Component: Compiler backend (e.g., annotation processors, code generators)
target:python
typ:bug
Type: Bug/defect
typ:enhance
Type: Enhancement/new feature
typ:refactor
Type: Refactoring (i.e., the same feature to end users but its internal change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #160.
deserialize_meta()
function provided by nirum-python runtime library.Nirum.Targets.Python.CodeGen
submodule.InstallRequires
type and functions related to it are merged intoCodeGenContext
.Please read added logs on CHANGES.md as well.