Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_matching: Use vcrpy #2127

Open
hseg opened this issue Jul 2, 2024 · 0 comments · Fixed by #2128 · May be fixed by #2174
Open

test_matching: Use vcrpy #2127

hseg opened this issue Jul 2, 2024 · 0 comments · Fixed by #2128 · May be fixed by #2174
Labels
Feature Request Feature Request

Comments

@hseg
Copy link

hseg commented Jul 2, 2024

Requested Feature

In view of #2111, any test that hits API endpoints should be using vcrpy, if only to make the tests less flaky. This is done for the tests in test/*/, but not for test/test_matching.py.

Possible implementation

Just add @pytest.mark.vcr() to tests/test_matching.py::test_ytmusic_matching and generate the cassettes.

@hseg hseg added the Feature Request Feature Request label Jul 2, 2024
@hseg hseg linked a pull request Aug 27, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature Request
Projects
None yet
1 participant