Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We do not need to release for project-used dependencies. #1193

Closed
Goooler opened this issue Jun 16, 2024 · 5 comments
Closed

We do not need to release for project-used dependencies. #1193

Goooler opened this issue Jun 16, 2024 · 5 comments

Comments

@Goooler
Copy link
Contributor

Goooler commented Jun 16, 2024

We do not need to release for project-used dependencies, things like this are just used to check and build this project, they are not the runtime needed.

Originally posted by @Goooler in #1192 (comment)

@Goooler
Copy link
Contributor Author

Goooler commented Jun 16, 2024

I didn't see where we make these automatic releases, but it's too bothering to update some revision updates, there is nothing changed between them like:

diffuse diff --jar spotbugs-gradle-plugin-6.0.16.jar spotbugs-gradle-plugin-6.0.17.jar

OLD: spotbugs-gradle-plugin-6.0.16.jar
NEW: spotbugs-gradle-plugin-6.0.17.jar

 JAR   │ old       │ new       │ diff
───────┼───────────┼───────────┼──────
 class │ 171.2 KiB │ 171.2 KiB │  0 B
 other │     260 B │     260 B │  0 B
───────┼───────────┼───────────┼──────
 total │ 171.5 KiB │ 171.5 KiB │  0 B

 CLASSES │ old │ new │ diff
─────────┼─────┼─────┼───────────
 classes │  44 │  44 │ 0 (+0 -0)
 methods │ 592 │ 592 │ 0 (+0 -0)
  fields │  81 │  81 │ 0 (+0 -0)

@Goooler
Copy link
Contributor Author

Goooler commented Jun 16, 2024

CC @KengoTODA

@KengoTODA
Copy link
Member

Our release note does not include changes like dependency updates, so what is the core of the problem? I want to understand why we care the post in such dev-deps update PRs.

https://github.com/spotbugs/spotbugs-gradle-plugin/releases/tag/6.0.17

@Goooler
Copy link
Contributor Author

Goooler commented Jun 20, 2024

As I described, some deps used by this project are just used for infra or building, they are not transitive deps that affect user sides, so we have no need to release them, it's so frequent.

And you can see the diff result above, nothing changed between these two versions.

@KengoTODA
Copy link
Member

KengoTODA commented Jun 22, 2024

Ah, I understand. Thanks for your explanation!

In my understanding, this release is necessary to support Android Plugin v8.5.0. In this case, we luckily had no changes, but in some cases, we needed to change our code. #946 needed to change Java version and #552 needed to change dependency (not sure why #552 was handled as chore(deps)).

So for me, it is understandable that Dependabot used fix for #1192.
Humans could change the commit comment manually only if no change is needed, but I think it's not so reasonable to ask contributors to do so.

If possible, I want to close this issue without any change, to keep the release procedure simple. How do you think? 🤔

@Goooler Goooler closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants