Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Task does not fail if report generation fails #929

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

KengoTODA
Copy link
Member

@KengoTODA KengoTODA commented Aug 1, 2023

Monitor the output from SpotBugs, and make the task failed if it contains related warning.

close #909

Signed-off-by: Kengo TODA <skypencil@gmail.com>
@KengoTODA KengoTODA self-assigned this Aug 1, 2023
Signed-off-by: Kengo TODA <skypencil@gmail.com>
Signed-off-by: Kengo TODA <skypencil@gmail.com>
@KengoTODA KengoTODA changed the title Fix #909 fix: Task does not fail if report generation fails Aug 2, 2023
@KengoTODA KengoTODA marked this pull request as ready for review August 2, 2023 11:48
@KengoTODA KengoTODA requested a review from a team August 2, 2023 11:48
Signed-off-by: Kengo TODA <skypencil@gmail.com>
Signed-off-by: Kengo TODA <skypencil@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@KengoTODA KengoTODA merged commit c6f2ec9 into master Aug 8, 2023
@KengoTODA KengoTODA deleted the issue-909 branch August 8, 2023 23:49
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🎉 This PR is included in version 5.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

KengoTODA added a commit that referenced this pull request Aug 10, 2023
Signed-off-by: Kengo TODA <skypencil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task does not fail if report generation fails
2 participants