Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle Int32 and Int64 in defaultValue evaluations #162

Merged
merged 3 commits into from
Jul 10, 2024
Merged

fix: handle Int32 and Int64 in defaultValue evaluations #162

merged 3 commits into from
Jul 10, 2024

Conversation

nicklasl
Copy link
Member

@nicklasl nicklasl commented Jul 10, 2024 •
edited
Loading

Evaluating Integer in the Confidence FlagEvaluation was not possible if the defaultValue was of type Int64 or Int32 instead of Int.

@nicklasl nicklasl changed the title test: write failing test for Integer issue fix: handle Int32 and Int64 in defaultValue evaluations Jul 10, 2024
@nicklasl nicklasl marked this pull request as ready for review July 10, 2024 08:09
@nicklasl nicklasl merged commit 6bb03d5 into main Jul 10, 2024
7 checks passed
@nicklasl nicklasl deleted the integer-bug branch July 10, 2024 08:21
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vahidlazio vahidlazio vahidlazio approved these changes

@fabriziodemaria fabriziodemaria Awaiting requested review from fabriziodemaria fabriziodemaria is a code owner

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicklasl @vahidlazio