fixed order of uri/base uri params; create undeclared uri params #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
econchick
force-pushed
the
lynn/fix-uri-params
branch
from
012d967 to
d3a58a7
Compare
Current coverage is
|
| path = path[0] | ||
|
|
||
| pattern = re.compile(r'\{(.*?)\}') | ||
| param_order = re.findall(pattern, path) |
There was a problem hiding this comment.
[nit] I would have extracted and tested the pattern matching stuff appart from the uri stuff
|
LGTM: makes me a little nervous to implement a pattern matching like specifically this with re, but I guess this is good enough if this is only used in the uri params stuff |
|
Thanks @tardyp ! Can you explain a little bit in more detail what your hesitation is with the pattern matching? |
econchick
added a commit
that referenced
this pull request
Feb 2, 2016
fixed order of uri/base uri params; create undeclared uri params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.