Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of missing values (NaN) #93

Open
otsaw opened this issue Oct 11, 2024 · 1 comment
Open

Handling of missing values (NaN) #93

otsaw opened this issue Oct 11, 2024 · 1 comment

Comments

@otsaw
Copy link

otsaw commented Oct 11, 2024

Hi! Is Voyager intended to handle missing values in some way? It might be useful to allow missing values in the query vector, in which case I think the search should consider other elements only. Would that be possible given the data structure you have, even if those queries would be less efficient?

I'm trying out the Python package and if I set an element in the query vector to numpy.nan, it seems to propagate so that all distances are NaN as well and the results don't seem meaningful.

@otsaw
Copy link
Author

otsaw commented Oct 18, 2024

For reference, what I'm looking for seems to be called "NaN-Euclidean" metric by some others:

scikit-learn/scikit-learn#25319

facebookresearch/faiss#3355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant