Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Store playlist name of unsyncable songs #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

c0ball
Copy link
Contributor

@c0ball c0ball commented Oct 26, 2024

Fixes #89

@c0ball
Copy link
Contributor Author

c0ball commented Oct 26, 2024

Now it should be fine

@timrae
Copy link
Collaborator

timrae commented Oct 28, 2024

I just tested and noticed this is generating one file per playlist rather than a single file for all the playlists as I believe is intended. So currently I would consider this a regression rather an advancement. There's also the existing issue that you don't get any log file if the script exits early due to an error.

So I would recommend that you should rather use the standard python logging library to fix these two issues

@c0ball
Copy link
Contributor Author

c0ball commented Nov 27, 2024

I am currently unable to debug this, as I can not find a playlist with unsyncable songs.
Would you mind sharing a playlist that causes this issue?

@timrae
Copy link
Collaborator

timrae commented Nov 28, 2024

Here's an album that fails, you could create a few playlists with diffrent tracks from this album to reproduce the issue I mentioned
https://open.spotify.com/album/0Pkamaa0inrBIDaZn6odNB?si=_rjtX5TEQnOmBIwQBfn2cw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add name of playlist to song not found file
2 participants