Skip to content
This repository was archived by the owner on May 31, 2022. It is now read-only.

Commit 92d02af

Browse files
jgrandjarwinch
authored andcommitted
Fix tests
1 parent 7d8fd25 commit 92d02af

File tree

5 files changed

+27
-2
lines changed

5 files changed

+27
-2
lines changed

Diff for: spring-security-oauth2/src/main/java/org/springframework/security/oauth2/client/http/OAuth2ErrorHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public void close() {
118118
}
119119

120120
public int getRawStatusCode() throws IOException {
121-
return response.getRawStatusCode();
121+
return this.getStatusCode().value();
122122
}
123123
};
124124

Diff for: spring-security-oauth2/src/test/java/org/springframework/security/oauth2/config/annotation/Gh808EnableAuthorizationServerTests.java

+7
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@
3333
import org.springframework.security.core.userdetails.UserDetailsService;
3434
import org.springframework.security.core.userdetails.UsernameNotFoundException;
3535
import org.springframework.security.crypto.codec.Base64;
36+
import org.springframework.security.crypto.password.NoOpPasswordEncoder;
37+
import org.springframework.security.crypto.password.PasswordEncoder;
3638
import org.springframework.security.oauth2.config.annotation.configurers.ClientDetailsServiceConfigurer;
3739
import org.springframework.security.oauth2.config.annotation.web.configuration.AuthorizationServerConfigurerAdapter;
3840
import org.springframework.security.oauth2.config.annotation.web.configuration.EnableAuthorizationServer;
@@ -188,5 +190,10 @@ public UserDetails loadUserByUsername(String username) throws UsernameNotFoundEx
188190
}
189191
};
190192
}
193+
194+
@Bean
195+
public PasswordEncoder passwordEncoder() {
196+
return NoOpPasswordEncoder.getInstance();
197+
}
191198
}
192199
}

Diff for: spring-security-oauth2/src/test/java/org/springframework/security/oauth2/config/annotation/ResourceServerConfigurationTests.java

+10
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
import org.springframework.security.config.annotation.web.configuration.WebSecurityConfigurerAdapter;
3737
import org.springframework.security.core.Authentication;
3838
import org.springframework.security.crypto.codec.Base64;
39+
import org.springframework.security.crypto.password.NoOpPasswordEncoder;
40+
import org.springframework.security.crypto.password.PasswordEncoder;
3941
import org.springframework.security.oauth2.common.DefaultOAuth2AccessToken;
4042
import org.springframework.security.oauth2.common.OAuth2AccessToken;
4143
import org.springframework.security.oauth2.config.annotation.configurers.ClientDetailsServiceConfigurer;
@@ -253,6 +255,10 @@ public void configure(ClientDetailsServiceConfigurer clients) throws Exception {
253255

254256
@Configuration
255257
protected static class SecurityConfiguration extends WebSecurityConfigurerAdapter {
258+
@Bean
259+
public PasswordEncoder passwordEncoder() {
260+
return NoOpPasswordEncoder.getInstance();
261+
}
256262
}
257263
}
258264

@@ -275,6 +281,10 @@ public void configure(AuthorizationServerEndpointsConfigurer endpoints) throws E
275281
}
276282
@Configuration
277283
protected static class SecurityConfiguration extends WebSecurityConfigurerAdapter {
284+
@Bean
285+
public PasswordEncoder passwordEncoder() {
286+
return NoOpPasswordEncoder.getInstance();
287+
}
278288
}
279289
}
280290

Diff for: spring-security-oauth2/src/test/resources/org/springframework/security/oauth2/config/xml/authorization-server-client-credentials-password-invalid.xml

+3
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252

5353
<authentication-manager id="usersAuthenticationManager">
5454
<authentication-provider>
55+
<password-encoder ref="passwordEncoder" />
5556
<user-service>
5657
<user name="acme" password="password" authorities="ROLE_USER" />
5758
</user-service>
@@ -65,4 +66,6 @@
6566
<oauth2:password authentication-manager-ref="usersAuthenticationManager" />
6667
</oauth2:authorization-server>
6768

69+
<b:bean id="passwordEncoder" class="org.springframework.security.crypto.password.NoOpPasswordEncoder" factory-method="getInstance" />
70+
6871
</b:beans>

Diff for: spring-security-oauth2/src/test/resources/org/springframework/security/oauth2/config/xml/authorization-server-client-credentials-password-valid.xml

+6-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@
3333
</b:bean>
3434

3535
<authentication-manager id="clientsAuthenticationManager">
36-
<authentication-provider user-service-ref="clientDetailsUserDetailsService" />
36+
<authentication-provider user-service-ref="clientDetailsUserDetailsService">
37+
<password-encoder ref="passwordEncoder" />
38+
</authentication-provider>
3739
</authentication-manager>
3840

3941
<b:bean id="clientDetailsUserDetailsService" class="org.springframework.security.oauth2.provider.client.ClientDetailsUserDetailsService">
@@ -46,6 +48,7 @@
4648

4749
<authentication-manager id="usersAuthenticationManager">
4850
<authentication-provider>
51+
<password-encoder ref="passwordEncoder" />
4952
<user-service>
5053
<user name="acme" password="password" authorities="ROLE_USER" />
5154
</user-service>
@@ -59,4 +62,6 @@
5962
<oauth2:password authentication-manager-ref="usersAuthenticationManager" />
6063
</oauth2:authorization-server>
6164

65+
<b:bean id="passwordEncoder" class="org.springframework.security.crypto.password.NoOpPasswordEncoder" factory-method="getInstance" />
66+
6267
</b:beans>

0 commit comments

Comments
 (0)