Skip to content

WARN: RefreshScope uses convention-based annotation attribute overrides #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmoayyed opened this issue Sep 19, 2022 · 3 comments · Fixed by #1151
Closed

WARN: RefreshScope uses convention-based annotation attribute overrides #1148

mmoayyed opened this issue Sep 19, 2022 · 3 comments · Fixed by #1151
Labels
Milestone

Comments

@mmoayyed
Copy link
Contributor

mmoayyed commented Sep 19, 2022

Describe the bug

  • Spring Cloud 4.0.0 M4
  • Spring Boot 3.0.0-M5
  • Spring 6.0.0-M6
WARN [org.springframework.core.annotation.AnnotationTypeMapping] - <Support for convention-based annotation attribute 
overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the 'proxyMode' attribute in 
@org.springframework.cloud.context.config.annotation.RefreshScope with an appropriate @AliasFor declaration -- for example, 
@AliasFor(annotation = org.springframework.context.annotation.Scope.class).>

Guess the relevant issue is here:
spring-projects/spring-framework#28760

I don't know if the suggestion is valid, but I can submit a pull request if you find this to be appropriate.

Thank you.

@sbrannen
Copy link

I don't know if the suggestion is valid

Yes, the suggestion is valid.

We do exactly that for @RequestScope in the core Spring Framework.

https://github.com/spring-projects/spring-framework/blob/6cb131ac7629cfda489d4d2367a36d44ee7b5ed2/spring-web/src/main/java/org/springframework/web/context/annotation/RequestScope.java#L61

@mmoayyed
Copy link
Contributor Author

Thank you. @spencergibb would you be OK with a pull request to remove the warning?

@spencergibb
Copy link
Member

PR would be welcome @mmoayyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants